-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
15 standardize linting #17
Conversation
| ✅ BASH | shfmt | list_of_files | 1 | 1 | 0 | 0.02s | @sir-sigurd I'd like to standardize all our coding style conventions around megalinter automation.
P.S. I fixed the execute bit, thanks for the catch. |
[GitHub Comment Reporter] Unable to post pull request comment: 403 {"message": "Resource not accessible by integration", "documentation_url": "https://docs.github.com/rest/issues/comments#create-an-issue-comment"}. To enable this function, please : 1. Create a Personal Access Token (https://docs.github.com/en/free-pro-team@latest/github/authenticating-to-github/creating-a-personal-access-token) 2. Create a secret named PAT with its value on your repository (https://docs.github.com/en/free-pro-team@latest/actions/reference/encrypted-secrets#creating-encrypted-secrets-for-a-repository)3. Define PAT={{secrets.PAT}} in your GitHub action environment variables [Updated Sources Reporter] copied 3 fixed source files in folder /github/workspace/megalinter-reports/updated_sources. Download it from artifacts then copy-paste it in your local repo to apply linters updates
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
FYI, it seems like 'shfmt' really does want to remove the execute bit, which might be a security recommendation. Also, this made me realize I have no clue when "deploy.sh" is called, or by whom, so I have no idea how to test (or configure) it. Can you enlighten me? |
), | ||
) | ||
benchling_tenant = troposphere.Parameter( | ||
"BenchlingTenant", | ||
template=cft, | ||
Type="String", | ||
AllowedPattern=r"^[^/]+$", | ||
Description="Benchling tenant name, i.e. $BenchlingTenant in " | ||
+ "https://$BenchlingTenant.benchling.com", | ||
Description="Benchling tenant name, i.e. $BenchlingTenant in " + "https://$BenchlingTenant.benchling.com", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not?
Description="Benchling tenant name, i.e. $BenchlingTenant in " + "https://$BenchlingTenant.benchling.com", | |
Description="Benchling tenant name, i.e. $BenchlingTenant in https://$BenchlingTenant.benchling.com", |
No description provided.